On Mon, 11 Aug 2025 16:43:05 GMT, Viktor Klang <vkl...@openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/VirtualThread.java line 324:
>> 
>>> 322:         } else {
>>> 323:             executor.execute(task);
>>> 324:         }
>> 
>> Is this worth special-casing—IIRC FJP::submit adapts the task if needed 
>> already.
>
> Ah, this is about getting a `AdaptedRunnableAction` rather than a 
> `RunnableExecuteAction` (where the latter is an InterruptibleTask, and the 
> former isn't). Sounds worth of a comment here?

Yes, it means we always adapt before calling submit, lazySubmit and 
externalSubmit rather than the mix of execute(Runnable) and xxxSubmit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26479#discussion_r2269004280

Reply via email to