On Fri, 29 Aug 2025 08:32:58 GMT, David Beaumont <d...@openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 95:
>> 
>>> 93:         }
>>> 94: 
>>> 95:         @Override
>> 
>> Discovered this method was missing during testing. I *think* this logic is 
>> what's needed here, but I would like someone to just double check.
>
> Is that thumbs up and confirmation that you've checked it?

@david-beaumont I think you need to override `getLocation` if you override 
`isResource` so image reader can actually fetch the data - unfortunately this 
is not clearly documented.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26757#discussion_r2311962049

Reply via email to