On Wed, 10 Sep 2025 19:57:56 GMT, Kieran Farrell <kfarr...@openjdk.org> wrote:
>> test/jdk/java/util/UUID/UUIDTest.java line 52: >> >>> 50: unixEpochTimeMillisTest(); >>> 51: unixEpochTimeMillisTest_Multi(); >>> 52: unixEpochTimeMillis_userInputTest(); >> >> Also rename the tests to use the `epochMillis` naming. > > Thanks Roger, I have updated the name accordingly. WRT updating the > implementation to use nextLong(), since we are no longer using the higher > percision bits in the first half of the UUID, we are using random bits in > their place, so we would need to call `nextLong` twice and overwrite with the > timestamp etc. if I understand correctly. From what ive seen in the > microbenchmarks, this results in a large perfomance dec. ok, looks good, allow some time for the other interested commenters to approve. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25303#discussion_r2341017995