On Tue, 9 Sep 2025 13:03:03 GMT, Emanuel Peter <[email protected]> wrote:
>> erifan has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Update the code comment
>
> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 1007:
>
>> 1005: testCompareMaskNotFloat(F_SPECIES, VectorOperators.NE, fa,
>> fninf, (m) -> { return F_SPECIES.maskAll(true).xor(m); });
>> 1006: verifyResultsFloat(F_SPECIES, VectorOperators.NE, fa, fninf);
>> 1007: }
>
> Do you have test cases for the cases other than `EQ` and `NE`? After all, we
> don't that someone accidentally messes with the logic you implemented later
> and we don't notice the bug ;)
For `float` and `double`, only `EQ` and `NE` are supported. So the positive
test only includes these two OPs. And we have one negative test for other
unsupported OPs, see `testCompareMaskNotFloatNegative`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2347761055
