On Wed, 1 Oct 2025 22:51:30 GMT, Justin Lu <[email protected]> wrote: >> Please review this PR which case folds grandfathered BCP47 tags on demand. >> (Instead of keeping the case compliant versions stored.) >> >> This facilitates the cleanup of the `LEGACY` map (which contains a String to >> String Array mapping). The 2D String array, creation and populating of the >> `LEGACY` map, as well as lower case folding of the legacy tags can now be >> removed from the static block of _sun.util.locale.LanguageTag_. >> >> Legacy tags are a small subset compared to the entire set of valid BCP47 >> tags. Reducing the cost for supporting them would be ideal. Instead, legacy >> tags can now be checked against and folded on demand via a switch statement. >> >> The commented grandfathered syntax is removed because the values themselves >> already exist as code, and the exact case can be found in the provided RFC >> link. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > implemenet Naoto's review
LGTM. Thanks for removing the (almost) unnecessary static initialization ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27596#pullrequestreview-3291472147
