On Mon, 6 Oct 2025 10:18:50 GMT, Darragh Clarke <[email protected]> wrote:
>> This PR is based on #25546 , though it was suggested to split that PR into 2 >> for easier reviewing and to give better visibility in the git history. >> This PR contains all the JExtract generated code that will be needed for >> converting Java's KQueue implementation to use Panama features instead of >> JNI. The actual updates to KQueue to make use of these files will come in >> the second PR. >> >> The basic structure here has the different native structures and methods >> split into 3 different packages all preceded by >> `src/java.base/macosx/classes/jdk/internal/ffi/generated/` >> Included in each package is a file `package-info.java` which contains the >> script that was used to generate these files so that others can reproduce >> them in future. >> >> The only modifications that have been made to the files post-generation are: >> - Adding copyright headers >> - Adding warning suppression for using restricted methods >> >> Some further modifications to these files to cut down on code duplication >> and adding support for errno handling on the native calls will come in the >> 2nd PR alongside the KQueue changes mentioned. > > Darragh Clarke has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed comment and fixed newlines at end of files LGTM ------------- Marked as reviewed by aefimov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27590#pullrequestreview-3305150054
