On Fri, 17 Oct 2025 12:59:42 GMT, Emanuel Peter <[email protected]> wrote:
>> Shawn M Emery has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updates for code review comments from @valeriepeng
>
> test/micro/org/openjdk/bench/javax/crypto/AESDecrypt.java line 44:
>
>> 42:
>> 43: @Param("10000000")
>> 44: private int count;
>
> Drive-by comment / question:
> Did you do all benchmarking with this single (quite large) size? How are the
> results for much smaller sizes? It may be worth it to just get a nice plot
> that goes over a range of sizes, to see if it behaves as expected.
The benchmarks listed in the PR description execute tests for data sizes
ranging from 16 to 10_000_000 bytes for decryption and encryption. The
difference in performance between the old and new code were within SE.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2440660231
