On Mon, 29 Sep 2025 21:21:38 GMT, Chen Liang <[email protected]> wrote:

>> ClassHierarchyResolver provided by users may sporadically run into 
>> exceptions due to reasons out of control, such as UncheckedIOException 
>> caused by a bad zip header. We should specify that users are allowed to fail 
>> their CHR when they encounter a failure when they support a ClassDesc to 
>> avoid hiding errors.
>
> Chen Liang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix non-IAE propagation

src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java 
line 79:

> 77:         } catch (Exception ex) {
> 78:             if (ex instanceof IllegalArgumentException iae)
> 79:                 throw iae;

Suggestion:

        } catch (IllegalArgumentException iae) {
            throw iae;
        } catch (RuntimeException ex) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27559#discussion_r2391644062

Reply via email to