On Tue, 23 Sep 2025 06:58:18 GMT, Guanqiang Han <[email protected]> wrote:
>> Please review this patch. >> >> **Description:** >> >> Currently, ModifiedUtf.utfLen returns a signed int. For very large strings, >> this may overflow and produce negative values, leading to incorrect behavior >> in code that relies on the UTF length. This patch changes the return type to >> long, which fully resolves the issue and allows safe handling of giant >> strings. >> >> **Test:** >> >> GHA > > Guanqiang Han has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - optimize test > - Merge remote-tracking branch 'upstream/master' into 8366421 > - Update and rename TestUtfLen.java to ModifiedUtfTest.java > > rename test > - Update TestUtfLen.java > > fix a small error > - Update TestUtfLen.java > > fix format error > - Update TestUtfLen.java > > Optimize regression test > - Update TestUtfLen.java > > update regression test > - add regression test > - Merge remote-tracking branch 'upstream/master' into 8366421 > - Change return type of utfLen to long to prevent overflow Looks good. Thanks for the clever HeaderCaptureOutputStream test. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27285#pullrequestreview-3260295775
