On Wed, 24 Sep 2025 08:21:33 GMT, Raffaello Giulietti <[email protected]> wrote:
>> Johannes Graham has updated the pull request incrementally with one >> additional commit since the last revision: >> >> VALUES_SIZE > > src/java.base/share/classes/java/text/DigitList.java line 326: > >> 324: boolean hasBeenRoundedUp = fdConverter.digitsRoundedUp(); >> 325: boolean valueExactAsDecimal = fdConverter.decimalDigitsExact(); >> 326: assert !fdConverter.isExceptional(); > > Maybe move this `assert` line at method entry. I moved it up as high as it can go. Alternatively, could be replaced with an assertion against the `source` parameter - `assert Double.isFinite(source)` ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27118#discussion_r2376043188
