On Fri, 17 Oct 2025 06:33:23 GMT, David Holmes <[email protected]> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   fix verify_frame_kind
>
> src/hotspot/share/runtime/synchronizer.hpp line 230:
> 
>> 228:   bool    _skip_exit;
>> 229:  public:
>> 230:   ObjectLocker(Handle obj, TRAPS);
> 
> I wonder if we should declare `PREEMPTABLE_TRAPS` as an indicator that the 
> only exception expected to come out of a call is the preempted-exception?

Not sure if I like that idea because then we might have to change other callers 
along the way for this new convention and everybody's already confused by TRAPS 
so then they'd be confused by a new TRAPS too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27802#discussion_r2460734436

Reply via email to