On Sat, 8 Nov 2025 04:21:17 GMT, Alexander Matveev <[email protected]> wrote:
>> - Added JDK specific keys/values to Info.plist of embedded runtime. >> - Modified `setFakeRuntime()` not to include `bin` folder. By default it was >> always included, but generated embedded runtime by default does not have >> `bin` folder. As a result `CustomInfoPListTest` failed. >> - Updated `CustomInfoPListTest` to test Info.plist with `bin` folder. > > Alexander Matveev has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains seven commits: > > - Merge remote-tracking branch 'upstream/master' into JDK-8363980 > - 8363980: [macos] Add JDK specific keys/values to Info.plist of embedded > runtime [v3] > - 8363980: [macos] Add JDK specific keys/values to Info.plist of embedded > runtime [v2] > - Merge remote-tracking branch 'upstream/master' into JDK-8363980 > - Merge remote-tracking branch 'upstream/master' into JDK-8363980 > - Merge remote-tracking branch 'upstream/master' into JDK-8363980 > - 8363980: [macos] Add JDK specific keys/values to Info.plist of embedded > runtime Loogs good. The missing piece is testing that the info plist file of the embedded runtime contains/doesn't contain JDK keys. For this purpose, I'd add a new item to the list of standard verifiers in the JPackageCommand class. This way, the info plist file of the embedded runtime will be automatically verified in all jpackage tests. Something like: ------------- PR Comment: https://git.openjdk.org/jdk/pull/28033#issuecomment-3514185661
