On Mon, 8 Dec 2025 13:32:54 GMT, Emanuel Peter <[email protected]> wrote:
>> Hamlin Li has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - remove log_warning >> - add test cases: BoolTest::ge/gt in enc_cmove_fp_cmp_fp > > test/hotspot/jtreg/compiler/c2/irTests/TestScalarConditionalMoveCmpObj.java > line 34: > >> 32: * @test >> 33: * @summary Test conditional move + compare object. >> 34: * @requires vm.simpleArch == "riscv64" > > It would be really nice if we generally have no platform requirements at the > top of the file, but just IR test applyIf instead. That way, everyone > benefits from everyone else's tests and we have less test duplication down > the line. addressed in https://github.com/openjdk/jdk/pull/28702. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28309#discussion_r2599583136
