On Mon, 26 Jan 2026 09:49:20 GMT, Andrew Haley <[email protected]> wrote:
> > Hi @theRealAph I have addressed all of your comments, thanks for your > > suggestions. > > > Please add the TypeNNVector JMH test files to this PR. > > > > > > These micro-benchmarks are already in the `panama-vector` project, do we > > need to sync that file separately into OpenJDK? > > Ideally, yes. It's a bit much to expect a reviewer to check out another repo. Yeah, I agree. VectorAPI is still in the incubator phase, so some code is first merged into the `panama-vector` project and then periodically synced to `OpenJDK`. Therefore, sometimes when the relevant JMH benchmark already exists in `panama-vector`, we don't add duplicates in the PR target to `OpenJDK`, but this makes code review somewhat inconvenient. But I wonder could we use a separate PR for this sync? Otherwise, we might import dozens or even hundreds of files into this PR, which I think would be difficult to review. Perhaps I should ask @PaulSandoz for his opinion on this issue. I’d really appreciate hearing your thoughts on it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28693#issuecomment-3802689436
