On Tue, 27 Jan 2026 08:46:53 GMT, Eric Fang <[email protected]> wrote:
>> There used to be a comment, would that one still be accurate? > > Yeah, the comment is still there, see line 92 of this file. I refactored this > file a bit, now it looks like this: > > // comment for testXXXCastToSameType > testOneCastToSameType() > testTwoCastToSameType() > > // comment for testXXXCastToDifferentType > testOneCastToDifferentType() > testTwoCastToDifferentType() Honestly, I prefer having comments next to the IR rule. If the IR rule fails, you instantly understand the assumptions with the comment. The IR rule could fail because: but or additional enhancements. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28313#discussion_r2730945272
