On Tue, 24 Feb 2026 09:27:56 GMT, Emanuel Peter <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions
>
> src/hotspot/share/opto/vectornode.cpp line 1194:
>
>> 1192:
>> 1193: // Helper function to select a vector operation with all broadcasted
>> inputs
>> 1194: bool VectorNode::can_push_broadcasts_across_vector_operation(BasicType
>> bt) {
>
> The comment does not quite seem to match here. We don't do any "selecting"
> here, we just check and return a boolean, right?
This reminds me of `push through phi` operations. Why not call it:
`can_push_through_broadcast`
Because I struggle to understand how one can push a broadcast "across" a vector
operation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25617#discussion_r2845682132
