On Wed, 25 Feb 2026 13:36:00 GMT, Chen Liang <[email protected]> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review comments resolution
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 46:
> 
>> 44: 
>> 45:   ciField* fd1 = ik->get_field_by_name(ciSymbols::CTYPE_name(), 
>> ciSymbols::class_signature(), /* is_static */ true);
>> 46:   assert(fd1 != nullptr, "element type info is missing");
> 
> We probably need separate asserts for CTYPE and ETYPE now, given these 
> asserts test all fields. Below assert comment should get an update too.

CTYPE is carrier type and it must be a java primitive type, In addition we have 
replaced ETYPE field with CTYPE from all concrete shuffle and mask classes. 
Thus CTYPE field primarily exists in all concrete mask / shuffle and vector 
classes and its type is being checked here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29629#discussion_r2853747571

Reply via email to