On Thu, 5 Feb 2026 09:57:05 GMT, Xiaohong Gong <[email protected]> wrote:
>> Eric Fang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refine the JTReg tests > > LGTM! Thanks for the update! > Hmm, what do @XiaohongGong @jatin-bhateja @iwanowww think about this? Where > should we add the vector nodes to the worklist? What is the best design, so > we can ensure IGVN always performs all the optimizations, no matter the > inlining order? To me, it's better to trigger IGVN for all vector nodes after (1) the compiler has finished incremental inlining for all APIs, and (2) all `VectorBox`/`VectorUnbox` nodes have been cleaned up or expanded—perhaps at the end of `PhaseVector::optimize_vector_boxes()`. At that point, the ideal graph should be relatively clean, and we no longer need to worry about IR optimizations being affected by edges from `VectorBox` nodes (an example: [1]). As for when to add vector nodes to the worklist, I’m fine with doing that during API inlining, as long as we can ensure that these nodes still exist by the time `PhaseVector` completes. [1] https://github.com/openjdk/jdk/pull/24674/changes/BASE..1b9c3b363fcc296956663249ef95d60a26a704d2#r2058061667 ------------- PR Comment: https://git.openjdk.org/jdk/pull/28313#issuecomment-4009097260
