On Wed, 25 Mar 2026 20:15:11 GMT, Andrey Turbanov <[email protected]> wrote:

>> Vector API anticipates to use Java declarations like sealed classes but 
>> missed them. We can easily add them to make future work in downstream like 
>> Valhalla easier.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line 
> 1176:
> 
>> 1174:  */
>> 1175: @SuppressWarnings("exports")
>> 1176: public sealed abstract class Vector<E> extends 
>> jdk.internal.vm.vector.VectorSupport.Vector<E> permits AbstractVector {
> 
> Use blessed modifiers order
> Suggestion:
> 
> public abstract sealed class Vector<E> extends 
> jdk.internal.vm.vector.VectorSupport.Vector<E> permits AbstractVector {

Yes, though it still feels weird to me that `sealed` is more important than 
`abstract` for API visibility except it comes later...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30414#discussion_r2990886072

Reply via email to