On Thu, 7 May 2026 16:16:18 GMT, Markus Grönlund <[email protected]> wrote:
>> I don't have any other comments, thanks for taking this on.
>
>> I don't have any other comments, thanks for taking this on.
>
> Many thanks for reviewing this, @AlanBateman. Cheers.
@mgronlun how important `jdk.jfr.internal.JVM::getClassId`?
While looking on external addresses referenced in C2 intrinsics we noticed that
JFR's `getClassId` is not generated:
1214 456 b 4 jdk.jfr.jvm.TestJFRIntrinsic::getClassIdIntrinsic (22
bytes)
@ 1 jdk.jfr.internal.JVM::getClassId (0 bytes)
failed to inline: native method
`_getClassId` is missing in LibraryCallKit::try_to_inline() and
C2Compiler::is_intrinsic_supported(). Even so we have
`LibraryCallKit::inline_native_classID()`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/30922#issuecomment-4401043001
