On Thu, 28 May 2026 00:30:03 GMT, Chen Liang <[email protected]> wrote:

>> make/RunTests.gmk line 212:
>> 
>>> 210:         TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY 
>>> JVMTI_STRESS_AGENT \
>>> 211:         MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT 
>>> REPORT \
>>> 212:         AOT_JDK MANUAL VALUE_CLASS_PLUGIN 
>>> $(CUSTOM_JTREG_SINGLE_KEYWORDS), \
>> 
>> When adding a new option for testing, please add documentation describing 
>> what it is and what it does in doc/testing.[md|html]. It's pretty obvious 
>> this has to do with value classes testing, but what does using the plugin 
>> actually do? Is the option name `VALUE_CLASS_PLUGIN` well suited for the 
>> purpose? By that I mean, is the important part that we are using a plugin, 
>> or that we are testing value classes, or something else?
>
> This guy runs by replacing some classes used in some collection tests with a 
> value class version. @bwhuang-us what do you think of this?

Sure, I will update the testing documentation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3319156503

Reply via email to