On Thu, 28 May 2026 22:58:44 GMT, John R Rose <[email protected]> wrote:

>> Vladimir Ivanov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix Compile::narrow_value
>
> src/hotspot/share/opto/compile.cpp line 5383:
> 
>> 5381:     result = phase->transform(new LShiftINode(value, 
>> phase->intcon(24)));
>> 5382:     result = new RShiftINode(result, phase->intcon(24));
>> 5383:   } else if (bt == T_BOOLEAN) {
> 
> Great catch.  Maybe scan for other T_BOOLEANs near other "FF" numbers or 
> "and" operations.

I think I found another one in  LIR_Assembler::const2mem; T_BYTE and T_BOOLEAN 
both use 0xFF as a mask.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31249#discussion_r3321170723

Reply via email to