On Mon, 1 Jun 2026 20:48:48 GMT, Ashay Rane <[email protected]> wrote:
>> Although the original implementation of `JLI_Open()` borrowed from the >> code in src/hotspot/os/windows/os_windows.cpp, the improvements to >> os_windows.cpp don't seem to have been applied to java_md.c, causing >> some tests to fail when the path to JAR files is longer than `MAXPATH` >> (i.e. 260) characters on Windows (see associated JBS issue 8385024 for >> details). Since `JLI_Open()` is not just invoked inside tests, this is >> not a test-specific issue, so fixing the test is not the right solution. >> >> This patch applies the recent changes from os_windows.cpp to java_md.c >> so that `JLI_Open()` can correctly handle longer than `MAXPATH` paths. >> The new code is almost the same as that in `wide_abs_unc_path()` in >> os_windows.cpp, except that the code in java_md.c uses `JLI_MemAlloc()` >> and `JLI_MemFree()` for memory allocation and deallocation. >> >> Although it would be ideal to have just one implementation between >> HotSpot and the launcher, the dependencies of the two components >> prevents us from having a single implementation. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ashay Rane has updated the pull request incrementally with one additional > commit since the last revision: > > Address PR comments > > 1. Use `Path.of(System.getProperty("user.dir"))` instead of > `Path.of(".").toAbsolutePath().normalize()` for clarity. > > 2. Fix year in copyright notices. Marked as reviewed by alanb (Reviewer). This would be architecturally problematic as it should only rely on the JNI Invocation API functions here and the JAR manifest is searched for SplashScreen-Image before the VM is created. ------------- PR Review: https://git.openjdk.org/jdk/pull/31209#pullrequestreview-4407768044 PR Comment: https://git.openjdk.org/jdk/pull/31209#issuecomment-4600059225
