On Mon, 15 Jun 2026 16:29:13 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/IdentityException.java line 52: > >> 50: * Create an {@code IdentityException} with the class name and >> default message. >> 51: * >> 52: * @param clazz the class of the object > > Nit - should the description instead be "the value class". The way it's > currently worded feels a bit odd. Should this constructor specify `NullPointerException` when the given `clazz` is `null`? > src/java.base/share/classes/jdk/internal/value/Deserializer.java line 22: > >> 20: * or visit www.oracle.com if you need additional information or have any >> 21: * questions. >> 22: */ > > The copyright text on this file appears to be incorrect. It's missing the > "Classpath" exception lines. This applies to some other new files introduced in this PR (and maybe the other open PRs related to this JEP too). For example `src/java.base/share/classes/java/lang/IdentityException.java` too is missing the "Classpath" exception. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3415017508 PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3414992989
