On Fri, 5 Jun 2026 20:58:17 GMT, Sandhya Viswanathan <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolution > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4543: > >> 4541: __ bind(stub.entry()); >> 4542: __ subptr(rsp, 8); >> 4543: __ movl(Address(rsp), src); > > The src also could be a higher bank register for APX, which could increase > the stub size by another byte. Done > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4568: > >> 4566: >> 4567: // Using the APX extended general purpose registers increases the >> instruction encoding size by 1 byte. >> 4568: int max_size = 23 + (UseAPX ? 1 : 0); > > This should be increase by 2 bytes here for APX. Done > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 5070: > >> 5068: } >> 5069: >> 5070: void >> C2_MacroAssembler::vector_cast_float16_to_int_special_cases(XMMRegister dst, >> XMMRegister src, XMMRegister xtmp1, > > This function is very similar to existing > vector_cast_float_to_int_special_cases_evex and > vector_cast_double_to_int_special_cases_evex. It would be good to combine > these with a parameter. Done > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 5092: > >> 5090: } >> 5091: >> 5092: void >> C2_MacroAssembler::vector_cast_float16_to_long_special_cases_evex(XMMRegister >> dst, XMMRegister src, XMMRegister xtmp1, > > This function is very similar to existing > vector_cast_float_to_long_special_cases_evex and > vector_cast_double_to_long_special_cases_evex. It would be good to combine > these with a parameter. Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3496277185 PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3496276922 PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3496277618 PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3496276674
