On Tue, 30 Jun 2026 15:03:31 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add local pools
>> - Add 4 nested levels
>
> src/java.base/share/classes/jdk/internal/foreign/ArenaImpl.java line 97:
>
>> 95: session.checkValidState();
>> 96: long pool = this.pool;
>> 97: if (pool == 0) {
>
> Should we do this here, or when the arena is created?
The advantage of this being here is that we only grab a pool when a user
actually allocates. I suppose the tradeoff here depends on how often users
create confined arenas that they don't allocate in.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31365#discussion_r3506788088
