On Thu, 9 Apr 2026 07:57:43 GMT, David Beaumont <[email protected]> wrote:

> Convert and tidy-up unit tests in test/jaxp/javax/xml/jaxp/unittest/stream.
> 
> It is recommended to set the diff settings in github to hide whitespace 
> (cog-wheel menu).
> 
> There are a lot of cases where manual catch blocks with explicit fail are 
> removed to just allow the test to fail idiomatically by throwing the 
> exception normally. This causes thousands of lines to be un-indented (with no 
> other change).
> 
> About 200 explicit uses of `fail()` were either removed or converted to 
> appropriate JUnit asserts.
> 
> There are also several non-trivial changes in this PR related to bad tests 
> where, for example, catching and ignoring exceptions allowed the test to pass 
> under all situations.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/30643

Reply via email to