On Thu, 30 Jul 2026 14:09:11 GMT, Alan Bateman <[email protected]> wrote:
>> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address jar spec change > > src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java > line 1718: > >> 1716: } >> 1717: String accessError = >> SecuritySupport.checkAccess(expandedSystemId, >> 1718: fSecurityManager, null, >> JdkConstants.ACCESS_EXTERNAL_ALL); > > Does eap = null just mean a null error message? The EAP covered DTD, XSD and XSL. So null here means no EAP property applies for this check. > src/java.xml/share/classes/jdk/xml/internal/AccessRule.java line 292: > >> 290: URI baseUri = URI.create(basePart); >> 291: boolean baseMatches = (jarBaseRule == null) || >> jarBaseRule.matches(baseUri); // wildcard/null means match any >> 292: boolean entryMatches = jarEntryPathPattern == null || >> jarEntryPathPattern.matches(entryPart); // always at least "/*" > > Is entryMatches left over from when the proposal matched on JAR entries? I forgot to update. "jar" spec has changed as of our latest discussion.This whole section is now removed. Also added test cases. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r3692392068 PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r3692380083
