On Tue, 4 Aug 2026 10:31:32 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add mising check
>
> src/java.base/share/classes/jdk/internal/foreign/layout/SequenceLayoutImpl.java
> line 135:
>
>> 133: } else {
>> 134: try {
>> 135: actualCount = Math.multiplyExact(elementCounts[i],
>> actualCount);
>
> There's one check missing -- a bit later, if one of the counts was `-1` we
> infer one -- and then update actualCount again. Now, in principle that should
> not lead to issues (because inference is done so that the missing dimension
> is expected/actual -- but worth checking).
Good catch! Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32191#discussion_r3719936733
