On Mon, 31 Aug 2026 15:50:09 GMT, Alan Bateman <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Remove unused method
>> - Pin virtual threads
>> - Update benchmarks
>
> src/java.base/share/classes/jdk/internal/foreign/ArenaImpl.java line 112:
>
>> 110: pool = ConfinedSegmentPool.acquire(session.owner);
>> 111: if (pool == 0) {
>> 112: pool =
>> ConfinedSegmentPool.allocateLocal(session.owner);
>
> These methods only work with the "current thread" so I'm wondering why the
> Thread parameter is needed. Each of the methods has an assert to check that
> the parameter is the current thread.
I'll guess the defensive check could be removed, and we could implicitly use
the current thread.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31365#discussion_r3903481213
