On Tue, 25 Aug 2026 07:48:48 GMT, Tobias Hartmann <[email protected]> wrote:
>> Fei Gao has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 11 additional commits >> since the last revision: >> >> - Extend the fix to Vector API masked operations >> - Merge branch 'master' into fix-long-redu-regression >> - Add Vector API IR test case >> - Add a VectorAPI micro-benchmark case >> - Merge branch 'master' into fix-long-redu-regression >> - Refine the comments >> - Add an IR test case and one extra benchmark case >> - Merge branch 'master' into fix-long-redu-regression >> - Dropped unrelated changes and added the AvoidMLAChain option to enable >> this optimization selectively on Neoverse cores >> - Merge branch 'master' into fix-long-redu-regression >> - ... and 1 more: https://git.openjdk.org/jdk/compare/23f41672...9c38d647 > > test/hotspot/jtreg/compiler/vectorization/TestVmlaAArch64.java line 91: > >> 89: } >> 90: for (int i = 0; i < ITERS; i++) { >> 91: lres = vector_add_dot_product(); > > I think the result, i.e. `lsres`, should be verified for correctness. Why do > we store it in a field? Done. Thanks! > test/hotspot/jtreg/compiler/vectorization/TestVmlaAArch64.java line 128: > >> 126: @Test >> 127: @IR(applyIfCPUFeature = {"sve", "true"}, >> 128: applyIfAnd = {"MaxVectorSize", "<= 16", "AvoidMLAChain", "true"}, > > Do we really need `"MaxVectorSize", "<= 16"` here if the test unconditionally > uses `SPECIES_128`? Done. Thanks for your reviewing, @TobiHartmann! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30237#discussion_r3924394062 PR Review Comment: https://git.openjdk.org/jdk/pull/30237#discussion_r3924399328
