On Tue, 8 Sep 2026 09:10:21 GMT, Per Minborg <[email protected]> wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - tweak comment >> - Fix issue where release is called even when acquire completes abnormally > > test/jdk/java/foreign/TestMappedSegmentKeepAlive.java line 72: > >> 70: Thread t = Thread.ofPlatform() >> 71: // Provoke a WrongThreadException when acquiring the >> session >> 72: // Make sure we properly release the session again > > If this assertion fails, the exception is not propagated to the main thread, > and the test succeeds. I know we are not testing WTE but would it make sense > to either propagate the exception or just swallow WTE in the worker thread? Good point. I think since we have an expectation in this test that a WTE will be thrown, we should check that. I'll propagate the exception to the main thread. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31918#discussion_r3957915773
