On Wed, 16 Sep 2026 12:13:16 GMT, Daniel Jeliński <[email protected]> wrote:

> Log the actual command output when it does not match expectations.
> 
> The test failed once in our CI, and the failure reason was not possible to 
> determine with the information available.
> 
> The test continues to pass.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/java/lang/ProcessBuilder/Basic.java line 1974:

> 1972:                             : "LC_ALL=C,"),
> 1973:                   "Incorrect handling of envstrings containing NULs, "+
> 1974:                     "got: >'" + commandOutput + "'<");

Hello Daniel, given that `systemRoot` and `libpath` are host dependent and we 
don't seem to print them anywhere in this test, could we also include the 
values of those 2 somewhere in this exception or at least as a separate message 
some place in this test? That might help why the equality check fails.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32902#discussion_r4026079557

Reply via email to