On Wed, 16 Sep 2026 01:06:21 GMT, David Holmes <[email protected]> wrote:
>> Dan Heidinga has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/share/classfile/loaderConstraints.cpp line 448:
>
>> 446: // so we don't have a dangling pointer to InstanceKlass in the
>> LoaderConstraintTable.
>> 447: void LoaderConstraintTable::check_failed_loaded_klass(InstanceKlass*
>> klass,
>> 448: ClassLoaderData*
>> loader) {
>
> Not sure this really carries its weight any more as it doesn't actually need
> to do anything. Based on the comments once we have added to the constraint
> table it should not be possible for there to be any exceptions that would
> require it to be removed again.
I'd like to keep it as an assert that the case we don't believe can happen
hasn't happened. Can we remove it in a future RFE?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32890#discussion_r4030311634
