On Fri, 16 Oct 2026 12:18:19 GMT, Viktor Klang <[email protected]> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains 11 additional 
>> commits since the last revision:
>> 
>>  - Specify fork to invoke onComplete if unable to create Thread
>>  - Merge branch 'master' into JDK-8391460
>>  - Merge branch 'master' into JDK-8391460
>>  - More API docs improvements
>>  - Merge branch 'master' into JDK-8391460
>>  - Merge branch 'master' into JDK-8391460
>>  - Improve wording
>>  - Merge branch 'master' into JDK-8391460
>>  - Improve API docs
>>  - Merge branch 'master' into JDK-8391460
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/f090970f...86aeb2ca
>
> src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java 
> line 101:
> 
>> 99:  * <ul>
>> 100:  * <li> The {@code fork} methods, the {@link #join()} method and {@link 
>> #close()} method
>> 101:  * may only be invoked by the <em>owner thread</em> (the thread that 
>> opened the {@code
> 
> Is it "may" or "must"?

Each method includes "This method may only be invoked by the scope owner" in 
its method description, and the `@throws` specifies the condition. I think what 
we have in the class description is okay (and hasn't changed) and also avoids 
creating any sense of "obligation" that moving to "must" will hint at.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32602#discussion_r4294778848

Reply via email to