On Fri, 6 Nov 2026 14:28:21 GMT, Chen Liang <[email protected]> wrote:

>> Deprecate the `contains` method on `java.util.Hashtable`, 
>> `java.util.Properties`, and `java.util.concurrent.ConcurrentHashMap` for 
>> being confusing with `containsKey`.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains four additional commits since 
> the last revision:
> 
>  - Simplify specs
>  - Merge branch 'master' of github.com:openjdk/jdk into 
> cleanup/hashtable-contains
>  - Redundant suppression
>  - Deprecate the hashtable contains methods

src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java line 
2151:

> 2149:      * This method is potentially confusing because its name does not 
> indicate
> 2150:      * whether it checks for the presence of a key or a value. Use 
> {@link
> 2151:      * #containsValue(Object) containsValue} instead.

Might make sense to say something akin to "use containsValue or containsKey 
instead".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33593#discussion_r4494988576

Reply via email to