On 2 April 2016 at 06:59, Brett Cannon <br...@python.org> wrote: > So this support of squash merging may be useful. It really depends on how we > try and support porting changes between versions and Misc/NEWS.
Having the bot handle squashing is likely still desirable, since the flow you really want is: - squash & rebase the PR - run the test suite/build the docs (depending on modified files) - commit if successful Having what-you-commit and what-you-tested be different always loses some of the benefits of pre-commit CI (regardless of whether the differences arise from merging, rebasing, squashing, or some combination thereof) There's still value in a "check" CI run to see whether a patch is even worth trying to commit, but it's a separate activity from actually gating commits on the test suite passing. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
