Awesome, thanks! On Wed, 8 Jun 2016 at 10:50 Anish Shah <shah.anis...@gmail.com> wrote:
> On Tue, Jun 7, 2016 at 9:48 PM, Brett Cannon <br...@python.org> wrote: > >> >> >> On Mon, 6 Jun 2016 at 13:20 Anish Shah <shah.anis...@gmail.com> wrote: >> >>> Hello everyone, >>> >>> This mail is about my progress so far in integrating GitHub and few >>> doubts/questions about how to do stuff. >>> >>> *Progress* >>> >>> *Show GitHub Pull Request comments on b.p.o*. [1] - Issue and review >>> comments will be added to the linked b.p.o issue. Only one comment will be >>> posted over 30 minutes. >>> >>> *Questions/Doubts* >>> >>> *Converting patches to pull requests *- First, let me tell you all my >>> approach and questions that I have. Please let me know if you have better >>> ways to do this. >>> >>> *Approach* >>> We need to have a git binary on b.p.o server and when a patch is >>> uploaded, we run a series of git commands from roundup to apply the patch, >>> commit using contributor's credentials, push the new branch and finally >>> create a new pull request using GitHub API. >>> >>> *Questions* >>> >>> 1. How should we inform the contributor about the newly created PR? >>> (S)he won't get subscribed to it automatically as the PR is created using >>> API. >>> >> >> A mention in the issue and in a GitHub comment should be enough. >> >> >>> >>> 2. What should we do an issue affects multiple versions? Should we open >>> multiple pull requests against each branch? >>> >> >> We have not decided how we want to handle this in the workflow. >> >> >>> >>> 3. There can be different patches for 2.7 and 3.x versions. Currently, >>> there's no way of determining which patch is for which branch. So, it would >>> be difficult to create a new pull request. >>> >> >> Yep, that's tricky. >> >> >>> >>> Looking forward to what you guys think. >>> >> >> Obviously what you work on is between you and Maciej, Anish, but I view >> this feature as low-priority. To me the two most important things are tying >> a pull request to an issue (I know you added a field but we will also need >> some GitHub web hook that will detect an issue in a PR title and >> automatically make the connection), and leaving a comment on an issue once >> a commit lands that mentions an issue in the commit message (like we >> currently do w/ hg). >> > > Thanks Brett. I have already submitted an initial patch for linking a > pull request to an issue using GitHub web hooks. :) > > > >> >> -Brett >> >> >>> >>> Thanks, >>> Anish Shah >>> >>> [1] http://psf.upfronthosting.co.za/roundup/meta/issue592 >>> _______________________________________________ >>> core-workflow mailing list >>> core-workflow@python.org >>> https://mail.python.org/mailman/listinfo/core-workflow >>> This list is governed by the PSF Code of Conduct: >>> https://www.python.org/psf/codeofconduct >> >>
_______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
