On Mon, Nov 27, 2017 at 2:10 PM, Victor Stinner
<victor.stin...@gmail.com> wrote:
> "Patch by" was useful with Mercurial which didn't allow to store an
> author and a committer. Git now stores the author and the committer:
>
> vstinner@apu$ git show --pretty=full
> 5b48dc638b7405fd9bde4d854bf477dfeaaddf44 --stat
> commit 5b48dc638b7405fd9bde4d854bf477dfeaaddf44
> Author: Jonas Haag <jo...@lophus.org>
> Commit: Antoine Pitrou <pit...@free.fr>
>
> I'm not sure about added *manually* the author in the NEWS entry. I
> would prefer to have a generated page like
> https://thanks.rust-lang.org/ to limit the work of the reviewer (and
> of the author).

thanks.rust-lang.org basically dumps all author names without giving
zero context. Contributor A might just a fix a typo or contribute a
non-trivial feature. There is no way to figure it out without doing
some research.

Instead, everyone who reads our changelog at
https://docs.python.org/3/whatsnew/changelog.html can see what
Contributor A exactly contributed to Python.

"Patch by" marker is already documented at
https://devguide.python.org/committing/#what-s-new-and-news-entries
and it's not hard to ask the contributor to add it. I usually add it
myself in less than a minute.

--Berker
_______________________________________________
core-workflow mailing list -- core-workflow@python.org
To unsubscribe send an email to core-workflow-le...@python.org
https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/
This list is governed by the PSF Code of Conduct: 
https://www.python.org/psf/codeofconduct

Reply via email to