On Fri, Jan 18, 2008 at 04:08:58PM +0100, [EMAIL PROTECTED] wrote:
> - See http://snapshots.linuxbios.org/
> + See http://tracker.coreboot.org/
snapshots in the tracker?
> -unsigned long write_linuxbios_table(
> +unsigned long write_coreboot_table(
Really?
> - /* Create cmos checksum entry in linuxbios table */
> + /* Create cmos checksum entry in coreboot table */
> lb_cmos_checksum(head);
Inconsistent since the function name doesn't change.
> struct lb_memory *get_lb_mem(void);
Likewise..
> -// Ported from Etherboot to LinuxBIOS 2005-08 by Steve Magnani
> +// Ported from Etherboot to coreboot 2005-08 by Steve Magnani
It wasn't called coreboot back then.
> - { LB_TAG_ASSEMBLER, linuxbios_assembler, },
> + { LB_TAG_ASSEMBLER, coreboot_assembler, },
LB_ ..
And probably many more. I stopped here.
I am with Carl-Daniel. I think we should consider reverting some
hunks of this patch.
//Peter
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
