Quoting Carl-Daniel Hailfinger <[EMAIL PROTECTED]>: > Hi! > > To bring this issue to an end, I resolved all conflicts the patch had > against the current tree and regenerated it without the controversial > id.lds section. > > On 09.01.2008 16:13, Marc Karasek wrote: >> Attached is the latest. >> >> It uses -ge instead of == or >. This will take care of any time that >> there are more than 1 build-id in the ld -help output. >> >> Myles Watson wrote: >>> I like the idea of using grep. It seems much cleaner, and avoids >>> that issue. >>> >>>> Myles Watson wrote: >>>> >>>>> On Jan 7, 2008 8:15 AM, Marc Karasek <[EMAIL PROTECTED]> wrote: >>>>> Sorry to be picky, but it seems like this breaks if they mention >>>>> build-id more than once in the help in the future. I think >0 would >>>>> be better than ==1. >>>>> >>>>> With that fixed, or if no one thinks that will ever happen: >>>>> Acked-by: Myles Watson <[EMAIL PROTECTED]> > > If we used grep, the buildtarget snippet could probably be made a bit > smaller: > ld --help | grep -q build-id && EXTRA_LFLAGS+=" -Wl,--build-id=none" > > > Next try (does not (yet?) use grep): > > Marc, I could not find your Signed-off-by: in the thread. If that patch > is OK for you, please sign off on it. > > > Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> > Works fine for me.
Acked-by: Joseph Smith <[EMAIL PROTECTED]> Thanks - Joe -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
