On 24.01.2008 20:05, ron minnich wrote: > On Jan 24, 2008 10:06 AM, Carl-Daniel Hailfinger > <[EMAIL PROTECTED]> wrote: > =================================================================== > >>> --- northbridge/amd/geodelx/vsmsetup.c (revision 0) >>> +++ northbridge/amd/geodelx/vsmsetup.c (revision 0) >>> @@ -0,0 +1,302 @@ >>> +/* >>> + * Erik Arjan Hendriks <[EMAIL PROTECTED]> >>> >>> >> Missing "copyright"? >> > > I will fix this. > >>> + * Copyright (C) 2000 Scyld. >>> + * Copyright (C) 2000 Scyld Computing Corporation >>> + * Copyright (C) 2001 University of California. LA-CC Number 01-67. >>> >>> >> Is LA-CC "Los Alamos Computer Code"? >> > > It actually depends on who you ask, but we have to leave that in there :-) >
I have no problem leaving it in there, I was just suggesting to add an explanation of the acronym to the header. >>> + buf = (unsigned char *)VSA2_BUFFER; >>> + // FIXME >>> + //olen = unrv2b((u8 *) rom, buf, &ilen); >>> >>> >> How exactly is the VSA going to end up in VSA2_BUFFER if you don't >> copy/uncompress it there? >> > > This code won't run yet. I am doing this initial commit as I don't > want to have another hard drive failure and lose it ... there is more > work to be done. > Yes. > This code moves the lx state from 'not working' to 'not working', so I > don't mind it too much. > At least the new state is closer to working. >> Rest looks good so far from a first glance. >> > > Good to hear. I would like to commit this because I am paranoid about > losing bits ... but I can try to fix that uncompress thing above. > With the fixes: Go ahead and commit. Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> Regards, Carl-Daniel -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
