* Patrick Georgi <[EMAIL PROTECTED]> [080126 18:30]:
> +void add_console(struct lb_header *header, u16 consoletype)
> +{
> +     struct lb_record *rec;
> +     struct lb_console *console;
> +     rec = lb_new_record(header);
> +     console = (struct lb_console *)lb_new_record(header);
> +     console->tag = LB_TAG_CONSOLE;
> +     console->size = sizeof(*console);
> +     console->type = LB_TAG_CONSOLE_SERIAL8250;
        
        Is there a reason you are hardcoding the type here, despite
passing one in add_console? ;-)

> +}

Otherwise I say 

Acked-by: Stefan Reinauer <[EMAIL PROTECTED]>

Will you implement using those table entries (at least vga and serial console)
for grub2?

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-- 
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to