On 17.02.2008 04:57, Peter Stuge wrote:
> On Sun, Feb 17, 2008 at 12:23:38AM +0100, Carl-Daniel Hailfinger wrote:
>   
>> All GeodeLX-based boards now include the geodelx/domain,
>> geodelx/apic and geodelx/pci dts files.
>>     
>
> Please add .dts to these filenames first, or do it along with the
> patch.
>
> If we do not start naming the dts files properly now, we may never.
>
> With rename:
>
> Acked-by: Peter Stuge <[EMAIL PROTECTED]>
>   

We can always rename stuff later. Right now the contents of all 
mainboard dts files except one don't even have the specified syntax. 
Conformance before cosmetics, I'd say.

So yes, I'd like to commit without the rename and leave the rename to a 
later commit (if any). Besides that, making the syntax conform to the 
spec is an entirely different change from moving and should be in a 
separate changeset.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/


-- 
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to