Author: stepan
Date: 2008-02-20 18:41:38 +0100 (Wed, 20 Feb 2008)
New Revision: 3112

Modified:
   trunk/coreboot-v2/src/arch/i386/include/arch/smp/mpspec.h
   trunk/coreboot-v2/src/arch/i386/smp/mpspec.c
   trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/get_bus_conf.c
   trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/irq_tables.c
   trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h
   trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mptable.c
   trunk/coreboot-v2/src/southbridge/nvidia/mcp55/mcp55_lpc.c
Log:
Route device IRQ through PCI bridge instead in mptable.
Don't enable pin0 for ioapic of io-4.

1. apic error in kernel for MB with mcp55+io55
2. some pcie-cards could have pci bridge there, so need to put entries
   for device under them in mptable.

Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
Acked-by: Stefan Reinauer <[EMAIL PROTECTED]>



Modified: trunk/coreboot-v2/src/arch/i386/include/arch/smp/mpspec.h
===================================================================
--- trunk/coreboot-v2/src/arch/i386/include/arch/smp/mpspec.h   2008-02-20 
15:59:30 UTC (rev 3111)
+++ trunk/coreboot-v2/src/arch/i386/include/arch/smp/mpspec.h   2008-02-20 
17:41:38 UTC (rev 3112)
@@ -248,6 +248,10 @@
        unsigned char irqtype, unsigned short irqflag,
        unsigned char srcbus, unsigned char srcbusirq,
        unsigned char dstapic, unsigned char dstirq);
+void smp_write_intsrc_pci_bridge(struct mp_config_table *mc,
+       unsigned char irqtype, unsigned short irqflag,
+       struct device *dev,
+       unsigned char dstapic, unsigned char *dstirq);
 void smp_write_lintsrc(struct mp_config_table *mc,
        unsigned char irqtype, unsigned short irqflag,
        unsigned char srcbusid, unsigned char srcbusirq,

Modified: trunk/coreboot-v2/src/arch/i386/smp/mpspec.c
===================================================================
--- trunk/coreboot-v2/src/arch/i386/smp/mpspec.c        2008-02-20 15:59:30 UTC 
(rev 3111)
+++ trunk/coreboot-v2/src/arch/i386/smp/mpspec.c        2008-02-20 17:41:38 UTC 
(rev 3112)
@@ -1,6 +1,7 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/path.h>
+#include <device/pci_ids.h>
 #include <cpu/cpu.h>
 #include <arch/smp/mpspec.h>
 #include <string.h>
@@ -26,8 +27,7 @@
        void *v;
        
        /* 16 byte align the table address */
-       addr += 15;
-       addr &= ~15;
+       addr = (addr + 0xf) & (~0xf);
        v = (void *)addr;
 
        mf = v;
@@ -52,8 +52,8 @@
 {
         struct intel_mp_floating *mf;
         void *v;
-
-        v = (void *)addr;
+       
+       v = (void *)addr;
         mf = v;
         mf->mpf_signature[0] = '_';
         mf->mpf_signature[1] = 'M';
@@ -204,7 +204,59 @@
 #endif
 }
 
+void smp_write_intsrc_pci_bridge(struct mp_config_table *mc,
+       unsigned char irqtype, unsigned short irqflag,
+       struct device *dev,
+       unsigned char dstapic, unsigned char *dstirq)
+{
+       struct device *child;
 
+       int linkn;
+       int i;
+       int srcbus;
+       int slot;
+
+       struct bus *link;
+       unsigned char dstirq_x[4];
+
+       for (linkn = 0; linkn < dev->links; linkn++) {
+
+               link = &dev->link[linkn];
+               child = link->children;
+               srcbus = link->secondary;
+
+               while (child) {
+                       if (child->path.type != DEVICE_PATH_PCI)
+                               goto next;
+
+                       slot = (child->path.u.pci.devfn >> 3);
+                       /* round pins */
+                       for (i = 0; i < 4; i++)
+                               dstirq_x[i] = dstirq[(i + slot) % 4];
+
+                       if ((child->class >> 16) != PCI_BASE_CLASS_BRIDGE) {
+                               /* pci device */
+                               printk_debug("route irq: %s %04x\n", 
dev_path(child));
+                               for (i = 0; i < 4; i++)
+                                       smp_write_intsrc(mc, irqtype, irqflag, 
srcbus, (slot<<2)|i, dstapic, dstirq_x[i]);
+                               goto next;
+                       }
+
+                       switch (child->class>>8) {
+                       case PCI_CLASS_BRIDGE_PCI:
+                       case PCI_CLASS_BRIDGE_PCMCIA:
+                       case PCI_CLASS_BRIDGE_CARDBUS:
+                               printk_debug("route irq bridge: %s %04x\n", 
dev_path(child));
+                               smp_write_intsrc_pci_bridge(mc, irqtype, 
irqflag, child, dstapic, dstirq_x);
+                       }
+
+               next:
+                       child = child->sibling;
+               }
+
+       }
+}
+
 void smp_write_lintsrc(struct mp_config_table *mc,
        unsigned char irqtype, unsigned short irqflag,
        unsigned char srcbusid, unsigned char srcbusirq,

Modified: trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/get_bus_conf.c
===================================================================
--- trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/get_bus_conf.c       
2008-02-20 15:59:30 UTC (rev 3111)
+++ trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/get_bus_conf.c       
2008-02-20 17:41:38 UTC (rev 3112)
@@ -35,7 +35,7 @@
 // Global variables for MB layouts and these will be shared by irqtable 
mptable and acpi_tables
 struct mb_sysconf_t mb_sysconf;
 
-unsigned pci1234x[] = 
+unsigned pci1234x[] =
 {        //Here you only need to set value in pci1234 for HT-IO that could be 
installed or not
         //You may need to preset pci1234 for HTIO board, please refer to 
src/northbridge/amd/amdk8/get_sblk_pci1234.c for detail
         0x0000ff0,
@@ -47,7 +47,7 @@
 //        0x0000ff0,
 //        0x0000ff0
 };
-unsigned hcdnx[] = 
+unsigned hcdnx[] =
 { //HT Chain device num, actually it is unit id base of every ht device in 
chain, assume every chain only have 4 ht device at most
        0x20202020,
        0x20202020,
@@ -98,18 +98,19 @@
         device_t dev;
         int i, j;
 
-        if(get_bus_conf_done==1) return; //do it only once
+        if (get_bus_conf_done)
+               return; //do it only once
 
         get_bus_conf_done = 1;
 
        sysconf.mb = &mb_sysconf;
-       
+
        m = sysconf.mb;
        memset(m, 0, sizeof(struct mb_sysconf_t));
 
         sysconf.hc_possible_num = sizeof(pci1234x)/sizeof(pci1234x[0]);
 
-        for(i=0;i<sysconf.hc_possible_num; i++) {
+        for (i = 0; i < sysconf.hc_possible_num; i++) {
                 sysconf.pci1234[i] = pci1234x[i];
                 sysconf.hcdn[i] = hcdnx[i];
         }
@@ -121,77 +122,41 @@
        m->sbdnb = (sysconf.hcdn[1] & 0xff); // first byte of second chain
 
        m->bus_type[0] = 1; //pci
-       
-       m->bus_mcp55[0] = (sysconf.pci1234[0] >> 16) & 0xff;
 
-                /* MCP55 */
-                dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sysconf.sbdn + 
0x06,0));
-                if (dev) {
-                        m->bus_mcp55[1] = pci_read_config8(dev, 
PCI_SECONDARY_BUS);
-                }
-                else {
-                        printk_debug("ERROR - could not find PCI 1:%02x.0, 
using defaults\n", sysconf.sbdn + 0x06);
-                }
+       m->bus_mcp55 = (sysconf.pci1234[0] >> 16) & 0xff;
 
-               for(i=2; i<8;i++) {
-                       dev = dev_find_slot(m->bus_mcp55[0], 
PCI_DEVFN(sysconf.sbdn + 0x0a + i - 2 , 0));
-                       if (dev) {
-                               m->bus_mcp55[i] = pci_read_config8(dev, 
PCI_SECONDARY_BUS);
-                       }
-                       else {
-                               printk_debug("ERROR - could not find PCI 
%02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2 );
-                       }
-               }
+       for (i = 0; i < sysconf.hc_possible_num; i++) {
+               unsigned busn_min, busn_max;
 
-               if(m->bus_mcp55[2]) {
-                       for(i=0;i<2; i++) {
-                               dev = dev_find_slot(m->bus_mcp55[2], 
PCI_DEVFN(0, i));
-                               if(dev) {
-                                       m->bus_pcix[0] = m->bus_mcp55[2];
-                                       m->bus_pcix[i+1] = 
pci_read_config8(dev, PCI_SECONDARY_BUS);
-                               }
-                       }
-               }
-               
-       for(i=0; i< sysconf.hc_possible_num; i++) {
-               if(!(sysconf.pci1234[i] & 0x1) ) continue;
+               if (!(sysconf.pci1234[i] & 0x1))
+                       continue;
 
-                unsigned busn = (sysconf.pci1234[i] >> 16) & 0xff;
-                unsigned busn_max = (sysconf.pci1234[i] >> 24) & 0xff;
-               for (j = busn; j <= busn_max; j++) 
+                busn_min = (sysconf.pci1234[i] >> 16) & 0xff;
+                busn_max = (sysconf.pci1234[i] >> 24) & 0xff;
+               for (j = busn_min; j <= busn_max; j++)
                        m->bus_type[j] = 1;
-               if(m->bus_isa <= busn_max) 
+               if(m->bus_isa <= busn_max)
                        m->bus_isa = busn_max + 1;
-               printk_debug("i=%d bus range: [%x, %x] bus_isa=%x\n",i, busn, 
busn_max, m->bus_isa);
+               printk_debug("i=%d bus range: [%x, %x] bus_isa=%x\n",i, 
busn_min, busn_max, m->bus_isa);
        }
 
                 /* MCP55b */
-        for(i=1; i< sysconf.hc_possible_num; i++) {
-               if (!(sysconf.pci1234[i] & 0x0f) ) continue;
+        for (i = 1; i < sysconf.hc_possible_num; i++) {
+               if (!(sysconf.pci1234[i] & 0x0f))
+                       continue;
                 // check hcid type here
                 sysconf.hcid[i] = get_hcid(i);
-                if (!sysconf.hcid[i]) continue; //unknown co processor
+                if (!sysconf.hcid[i])
+                       continue; //unknown co processor
 
-               m->bus_mcp55b[0] = (sysconf.pci1234[1]>>16) & 0xff;
-               m->bus_mcp55b[1] = m->bus_mcp55b[0]+1; //fake pci
-
-               for(i=2; i<8;i++) {
-                       dev = dev_find_slot(m->bus_mcp55b[0], 
PCI_DEVFN(m->sbdnb + 0x0a + i - 2 , 0));
-                       if (dev) {
-                               m->bus_mcp55b[i] = pci_read_config8(dev, 
PCI_SECONDARY_BUS);
-                       }
-                       else {
-                               printk_debug("ERROR - could not find PCI 
%02x:%02x.0, using defaults\n", m->bus_mcp55b[0], m->sbdnb + 0x0a + i - 2 );
-                       }
-               }
+               m->bus_mcp55b = (sysconf.pci1234[1]>>16) & 0xff;
        }
 
-
 /*I/O APICs:   APIC ID Version State           Address*/
 #if CONFIG_LOGICAL_CPUS==1
        apicid_base = get_apicid_base(2);
-#else 
-       apicid_base = CONFIG_MAX_PHYSICAL_CPUS; 
+#else
+       apicid_base = CONFIG_MAX_PHYSICAL_CPUS;
 #endif
        m->apicid_mcp55 = apicid_base+0;
         m->apicid_mcp55b = apicid_base+1;

Modified: trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/irq_tables.c
===================================================================
--- trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/irq_tables.c 2008-02-20 
15:59:30 UTC (rev 3111)
+++ trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/irq_tables.c 2008-02-20 
17:41:38 UTC (rev 3112)
@@ -78,15 +78,15 @@
 
        pirq = (void *)(addr);
        v = (uint8_t *)(addr);
-       
+
        pirq->signature = PIRQ_SIGNATURE;
        pirq->version  = PIRQ_VERSION;
-       
-       pirq->rtr_bus = m->bus_mcp55[0];
+
+       pirq->rtr_bus = m->bus_mcp55;
        pirq->rtr_devfn = ((sbdn+6)<<3)|0;
 
        pirq->exclusive_irqs = 0;
-       
+
        pirq->rtr_vendor = 0x10de;
        pirq->rtr_device = 0x0370;
 
@@ -97,10 +97,10 @@
        pirq_info = (void *) ( &pirq->checksum + 1);
        slot_num = 0;
 //pci bridge
-       write_pirq_info(pirq_info, m->bus_mcp55[0], ((sbdn+6)<<3)|0, 0x1, 
0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
+       write_pirq_info(pirq_info, m->bus_mcp55, ((sbdn+6)<<3)|0, 0x1, 0xdef8, 
0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0);
        pirq_info++; slot_num++;
-        
-        for(i=1; i< sysconf.hc_possible_num; i++) {
+
+        for (i = 1; i < sysconf.hc_possible_num; i++) {
                 if(!(sysconf.pci1234[i] & 0x1) ) continue;
                 unsigned busn = (sysconf.pci1234[i] >> 16) & 0xff;
                 unsigned devn = sysconf.hcdn[i] & 0xff;
@@ -109,10 +109,10 @@
                 pirq_info++; slot_num++;
        }
 
-       pirq->size = 32 + 16 * slot_num; 
+       pirq->size = 32 + 16 * slot_num;
 
         for (i = 0; i < pirq->size; i++)
-                sum += v[i];   
+                sum += v[i];
 
        sum = pirq->checksum - sum;
 

Modified: trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h
===================================================================
--- trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h 2008-02-20 
15:59:30 UTC (rev 3111)
+++ trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h 2008-02-20 
17:41:38 UTC (rev 3112)
@@ -24,12 +24,11 @@
 
 struct mb_sysconf_t {
         unsigned char bus_isa;
-        unsigned char bus_mcp55[8]; //1
-        unsigned char bus_mcp55b[8];//a
+        unsigned char bus_mcp55;
+        unsigned char bus_mcp55b;
         unsigned apicid_mcp55;
         unsigned apicid_mcp55b;
        unsigned bus_type[256]; 
-       unsigned char bus_pcix[3]; // under bus_mcp55_2
 
        unsigned sbdnb;
 

Modified: trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mptable.c
===================================================================
--- trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mptable.c    2008-02-20 
15:59:30 UTC (rev 3111)
+++ trunk/coreboot-v2/src/mainboard/nvidia/l1_2pvv/mptable.c    2008-02-20 
17:41:38 UTC (rev 3112)
@@ -39,6 +39,7 @@
        unsigned sbdn;
 
        int i,j;
+       unsigned char apicpin[4];
 
         mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN);
         memset(mc, 0, sizeof(*mc));
@@ -65,8 +66,8 @@
 
 /*Bus:         Bus ID  Type*/
        /* define bus and isa numbers */
-        for(j= 0; j < 256 ; j++) {
-               if(m->bus_type[j])
+        for (j = 0; j < 256 ; j++) {
+               if (m->bus_type[j])
                         smp_write_bus(mc, j, "PCI   ");
         }
         smp_write_bus(mc, m->bus_isa, "ISA   ");
@@ -77,38 +78,43 @@
                struct resource *res;
                uint32_t dword;
 
-                dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sbdn+ 0x1,0));
+                dev = dev_find_slot(m->bus_mcp55, PCI_DEVFN(sbdn+ 0x1,0));
                 if (dev) {
                        res = find_resource(dev, PCI_BASE_ADDRESS_1);
-                       if (res) {
+                       if (res)
                                smp_write_ioapic(mc, m->apicid_mcp55, 0x11, 
res->base);
-                       }
 
+               /* Initialize interrupt mapping*/
+                       dword = pci_read_config32(dev, 0x74);
+                       dword &= ~(1<<15);
+                       dword |= 1<<2;
+                       pci_write_config32(dev, 0x74, dword);
+
                        dword = 0x43c6c643;
-                       pci_write_config32(dev, 0x7c, dword);
+                       pci_write_config32(dev, 0x7c, dword);
 
                        dword = 0x81001a00;
                        pci_write_config32(dev, 0x80, dword);
 
-                       dword = 0xd00012d2;
+                       dword = 0xd00012d2;
                        pci_write_config32(dev, 0x84, dword);
 
                 }
 
-           if(m->bus_mcp55b[0]) {
-                dev = dev_find_slot(m->bus_mcp55b[0], PCI_DEVFN(m->sbdnb + 
0x1,0));
+           if (m->bus_mcp55b) {
+                dev = dev_find_slot(m->bus_mcp55b, PCI_DEVFN(m->sbdnb + 
0x1,0));
                 if (dev) {
                        res = find_resource(dev, PCI_BASE_ADDRESS_1);
-                       if (res) {
+                       if (res)
                                smp_write_ioapic(mc, m->apicid_mcp55b, 0x11, 
res->base);
-                       }
+
                        dword = 0x43c60000;
-                       pci_write_config32(dev, 0x7c, dword);
+                       pci_write_config32(dev, 0x7c, dword);
 
                        dword = 0x81000000;
                        pci_write_config32(dev, 0x80, dword);
 
-                       dword = 0xd00002d0;
+                       dword = 0xd00002d0;
                        pci_write_config32(dev, 0x84, dword);
 
                 }
@@ -116,8 +122,8 @@
            }
 
        }
-  
-                  /*I/O Ints:  Type    Polarity    Trigger                     
Bus ID   IRQ    APIC ID PIN# */ 
+
+                  /*I/O Ints:  Type    Polarity    Trigger                     
Bus ID   IRQ    APIC ID PIN# */
        smp_write_intsrc(mc, mp_ExtINT, 
MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, m->bus_isa, 0x0, m->apicid_mcp55, 
0x0);
        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH,  
m->bus_isa, 0x1, m->apicid_mcp55, 0x1);
        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH,  
m->bus_isa, 0x0, m->apicid_mcp55, 0x2);
@@ -131,63 +137,65 @@
        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH,  
m->bus_isa, 0xe, m->apicid_mcp55, 0xe);
        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH,  
m->bus_isa, 0xf, m->apicid_mcp55, 0xf);
 
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+1)<<2)|1, m->apicid_mcp55, 0xa);
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+1)<<2)|1, m->apicid_mcp55, 0xa); // 10
 
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+2)<<2)|0, m->apicid_mcp55, 0x16); // 22
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+2)<<2)|0, m->apicid_mcp55, 0x16); // 22
 
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+2)<<2)|1, m->apicid_mcp55, 0x17); // 23
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+2)<<2)|1, m->apicid_mcp55, 0x17); // 23
 
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+6)<<2)|1, m->apicid_mcp55, 0x17); // 23
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+6)<<2)|1, m->apicid_mcp55, 0x17); // 23
 
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+5)<<2)|0, m->apicid_mcp55, 0x14); // 20
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+5)<<2)|1, m->apicid_mcp55, 0x17); // 23
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+5)<<2)|2, m->apicid_mcp55, 0x15); // 21
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+5)<<2)|0, m->apicid_mcp55, 0x14); // 20
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+5)<<2)|1, m->apicid_mcp55, 0x17); // 23
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+5)<<2)|2, m->apicid_mcp55, 0x15); // 21
 
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+8)<<2)|0, m->apicid_mcp55, 0x16); // 22
-        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55[0], ((sbdn+9)<<2)|0, m->apicid_mcp55, 0x15); // 21
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+8)<<2)|0, m->apicid_mcp55, 0x16); // 22
+        smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, 
m->bus_mcp55, ((sbdn+9)<<2)|0, m->apicid_mcp55, 0x15); // 21
 
-       for(j=7; j>=2; j--) {
-               if(!m->bus_mcp55[j]) continue;
-               for(i=0;i<4;i++) {
-                       smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[j], (0x00<<2)|i, 
m->apicid_mcp55, 0x10 + (2+j+i+4-sbdn%4)%4);
-               }
+//Slot PCIE
+       for (j = 2; j < 8; j++) {
+                device_t dev;
+               dev = dev_find_slot(m->bus_mcp55, PCI_DEVFN(sbdn + 0x0a + j - 2 
, 0));
+               if (!dev || !dev->enabled)
+                       continue;
+               for (i = 0; i < 4; i++)
+                       apicpin[i] = 0x10 + (2+j+i+4-sbdn%4)%4;
+               smp_write_intsrc_pci_bridge(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, dev, m->apicid_mcp55, apicpin);
        }
 
-       for(j=0; j<2; j++) 
-               for(i=0;i<4;i++) {
-                       smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[1], ((0x06+j)<<2)|i, 
m->apicid_mcp55, 0x10 + (2+i+j)%4);
-               }
+//Slot PCI 32
+       {
+                device_t dev;
+               dev = dev_find_slot(m->bus_mcp55, PCI_DEVFN(sbdn + 6 , 0));
+               if (dev && dev->enabled) {
+                       for (i = 0; i < 4; i++)
+                               apicpin[i] = 0x10 + (2+i)%4;
+                       smp_write_intsrc_pci_bridge(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, dev, m->apicid_mcp55, apicpin);
+               }
+       }
 
-       if(m->bus_mcp55b[0]) {
-               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b[0], 
((m->sbdnb+5)<<2)|0, m->apicid_mcp55b, 0x14); // 20
-               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b[0], 
((m->sbdnb+5)<<2)|1, m->apicid_mcp55b, 0x17); // 23
-               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b[0], 
((m->sbdnb+5)<<2)|2, m->apicid_mcp55b, 0x15); // 21
+       if (m->bus_mcp55b) {
+               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b, ((m->sbdnb+5)<<2)|0, 
m->apicid_mcp55b, 0x14); // 20
+               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b, ((m->sbdnb+5)<<2)|1, 
m->apicid_mcp55b, 0x17); // 23
+               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b, ((m->sbdnb+5)<<2)|2, 
m->apicid_mcp55b, 0x15); // 21
 
-               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b[0], 
((m->sbdnb+8)<<2)|0, m->apicid_mcp55b, 0x16); // 22
-               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b[0], 
((m->sbdnb+9)<<2)|0, m->apicid_mcp55b, 0x15); // 21
+               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b, ((m->sbdnb+8)<<2)|0, 
m->apicid_mcp55b, 0x16); // 22
+               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b, ((m->sbdnb+9)<<2)|0, 
m->apicid_mcp55b, 0x15); // 21
 
 
-               for(j=7; j>=2; j--) {
-                       if(!m->bus_mcp55b[j]) continue;
-                       for(i=0;i<4;i++) {
-                               smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55b[j], (0x00<<2)|i, 
m->apicid_mcp55b, 0x10 + (2+j+i+4-m->sbdnb%4)%4);
+       //Slot  PCIE
+               for (j = 2; j < 8; j++) {
+                       device_t dev;
+                       dev = dev_find_slot(m->bus_mcp55b, PCI_DEVFN(m->sbdnb + 
0x0a + j - 2 , 0));
+                       if (!dev || !dev->enabled)
+                               continue;
+                       for (i = 0; i < 4; i++) {
+                               apicpin[i] = 0x10 + (2+j+i+4-m->sbdnb%4)%4;
                        }
+                       smp_write_intsrc_pci_bridge(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, dev, m->apicid_mcp55b, apicpin);
                }
-       }
-#if 1
 
-       if(m->bus_pcix[0]) {    
-
-               for(i=0;i<2;i++) {
-                       smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_pcix[2], (4<<2)|i, 
m->apicid_mcp55, 0x10 + (0+i+4-sbdn%4)%4); //16, 17 
-               }
-
-
-               for(i=0;i<4;i++) {
-                       smp_write_intsrc(mc, mp_INT, 
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_pcix[1], (4<<2)|i, 
m->apicid_mcp55, 0x10 + (2+i+4-sbdn%4)%4); // 18, 19, 16, 17
-               }
        }
-#endif
 
 /*Local Ints:  Type    Polarity    Trigger     Bus ID   IRQ    APIC ID PIN#*/
        smp_write_intsrc(mc, mp_ExtINT, 
MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, m->bus_isa, 0x0, MP_APIC_ALL, 0x0);

Modified: trunk/coreboot-v2/src/southbridge/nvidia/mcp55/mcp55_lpc.c
===================================================================
--- trunk/coreboot-v2/src/southbridge/nvidia/mcp55/mcp55_lpc.c  2008-02-20 
15:59:30 UTC (rev 3111)
+++ trunk/coreboot-v2/src/southbridge/nvidia/mcp55/mcp55_lpc.c  2008-02-20 
17:41:38 UTC (rev 3112)
@@ -87,7 +87,7 @@
        /* Be careful and don't write past the end... */
 };
 
-static void setup_ioapic(unsigned long ioapic_base)
+static void setup_ioapic(unsigned long ioapic_base, int master)
 {
        int i;
        unsigned long value_low, value_high;
@@ -95,7 +95,14 @@
        volatile unsigned long *l;
        struct ioapicreg *a = ioapicregvalues;
 
-       ioapicregvalues[0].value_high = lapicid()<<(56-32);
+       if (master) {
+               ioapicregvalues[0].value_high = lapicid()<<(56-32);
+               ioapicregvalues[0].value_low = ENABLED | TRIGGER_EDGE | 
POLARITY_HIGH | PHYSICAL_DEST | ExtINT;
+       }
+       else {
+               ioapicregvalues[0].value_high = NONE;
+               ioapicregvalues[0].value_low = DISABLED;
+       }
 
        l = (unsigned long *) ioapic_base;
 
@@ -121,14 +128,14 @@
 
 #define MAINBOARD_POWER_OFF    0
 #define MAINBOARD_POWER_ON     1
-#define SLOW_CPU_OFF   0
-#define SLOW_CPU__ON   1
+#define SLOW_CPU_OFF           0
+#define SLOW_CPU__ON           1
 
 #ifndef MAINBOARD_POWER_ON_AFTER_POWER_FAIL
-#define MAINBOARD_POWER_ON_AFTER_POWER_FAIL    MAINBOARD_POWER_ON
+#define MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON
 #endif
 
-static void lpc_common_init(device_t dev)
+static void lpc_common_init(device_t dev, int master)
 {
        uint8_t byte;
        uint32_t dword;
@@ -139,13 +146,12 @@
        pci_write_config8(dev, 0x74, byte);
        dword = pci_read_config32(dev, PCI_BASE_ADDRESS_1); // 0x14
 
-       setup_ioapic(dword);
-
+       setup_ioapic(dword, master);
 }
 
 static void lpc_slave_init(device_t dev)
 {
-       lpc_common_init(dev);
+       lpc_common_init(dev, 0);
 }
 
 #if 0
@@ -166,13 +172,12 @@
        int on;
        int nmi_option;
 
-       lpc_common_init(dev);
+       lpc_common_init(dev, 1);
 
 #if 0
        /* posted memory write enable */
        byte = pci_read_config8(dev, 0x46);
        pci_write_config8(dev, 0x46, byte | (1<<0));
-
 #endif
        /* power after power fail */
 
@@ -198,7 +203,7 @@
                dword = inl(pm10_bar + 0x10);
                on = 8-on;
                printk_debug("Throttling CPU %2d.%1.1d percent.\n",
-                               (on*12)+(on>>1),(on&1)*5);
+                            (on*12)+(on>>1),(on&1)*5);
        }
 
 #if 0


-- 
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to