On Wed, Jun 04, 2008 at 02:24:23PM +0200, Carl-Daniel Hailfinger wrote: > > +++ southbridge/amd/cs5536/cs5536.c (working copy) > > @@ -395,18 +395,19 @@ > > } > > } > > > > -#define HCCPARAMS 0x08 > > -#define IPREG04 0xA0 > > +/* the /sizeof(unsigned long) is to convert byte offsets into u32 offsets > > */ > > > > sizeof(unsigned long) is u64 for 64bit architectures.
Note which file this is in. I doubt the 5536 will be used on a 64 bit CPU anytime soon. > I suggest either sizeof(u32) or sizeof(int). Though I consider this only cosmetic, I agree that u32 is nicer. Also since it is mentioned in the comment. > The indentation looks strange as well. Maybe because patch is being viewed and there are some odd tabs or other spacing in the original file. I found that applying the patch is the only way to reliably detect whitespace problems. Ron, if you feel like it, make those unsigned longs u32s, if not, still: Acked-by: Peter Stuge <[EMAIL PROTECTED]> -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
