On Thu, Jun 19, 2008 at 04:49:13PM -0600, Jordan Crouse wrote:
> Greetings.  I am very happy to present to you the next version of the
> proof-of-concept for Bayou, the Coreboot payload chooser.

Sweet! :)

I have not yet tested it, but I encountered an issue in the 0.2
blar Makefile that I never sent a patch for. It remains in pbuilder
so here's the patch!

Oh - and please run make clean before packaging the next tarball so
that x86_64 lzma/*.o aren't included - they don't work here. :)

I think bayou is so neat! Thanks a lot for your efforts!


//Peter
bayou: Fix up pbuilder Makefile a bit so make and make clean work as expected

The problem solved is that $(LZMA_OBJ) only was defined by the include,
which came after the pbuilder rule, so simple "make" in the pbuilder dir
didn't work. Also let make clean properly clean out lzma object files.

Signed-off-by: Peter Stuge <[EMAIL PROTECTED]>

diff -ru payload-builder.orig/Makefile payload-builder/Makefile
--- payload-builder.orig/Makefile	2008-06-20 00:33:21.000000000 +0200
+++ payload-builder/Makefile	2008-06-20 01:04:00.000000000 +0200
@@ -3,17 +3,20 @@
 INCLUDES := -Iliblar/
 CFLAGS=-Wall -Werror -g
 
-pbuilder: $(PBUILDOBJS) $(LZMA_OBJ) liblar/liblar.a
-	$(CXX) -o $@ $(PBUILDOBJS) $(LZMA_OBJ) -L ./liblar -llar -lexpat
+all: pbuilder
+
+include lzma/Makefile
 
 liblar/liblar.a:
 	make -C liblar
 
-include lzma/Makefile
+pbuilder: $(PBUILDOBJS) $(LZMA_OBJ) liblar/liblar.a
+	$(CXX) -o $@ $(PBUILDOBJS) $(LZMA_OBJ) -L ./liblar -llar -lexpat
 
 %.o: %.c
 	$(CC) -c $(CFLAGS) $(INCLUDES) -o $@ $<
 
+.PHONY: clean
 clean:
-	rm -f pbuilder *.o
+	rm -f pbuilder *.o lzma/*.o
 	make -C liblar clean
-- 
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to