On 22.06.2008 12:24, Stefan Reinauer wrote: > Peter Stuge wrote: > >> Patch attached. >> >> >> //Peter >> >> flashrom: Remove dead M-Systems Disk on Chip code >> >> DOC support has been disabled by default for many years. The write function >> does nothing but print text. It has a call to write_page_md2802() commented >> out, but that function does not exist. This is dead code with ugly #ifdefs. >> >> Updates README to reflect that there was a time when there was code, but it >> didn't work. Removes M-Systems #defines and also includes svn rm msys_doc.* >> >> Signed-off-by: Peter Stuge <[EMAIL PROTECTED]> >> > > Absolutely NACK. > > The reason the code is not compiled in per default is that the probing > takes forever. Still, no reason to drop support. >
No, the flashrom DoC code in subversion never worked. The write functions were commented out already at the time flashrom was checked in into the v2 tree at the end of the year 2003. The code in flashrom has been useless since forever. By the way, I checked the DoC code in another repository (v1 flash_and_burn), and that code also never worked. > I don't think we should drop features because we don't like a few ifdefs. > Agreed. Dropping code that _never_ worked is very reasonable, though. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
