On Sat, Jun 28, 2008 at 07:37:53PM +0200, Stefan Reinauer wrote: > > I had an idea. The attached patch fixes flashrom 3393 on non-SPI ICH7 > > at least for the reporter. > > Yes, that fix is fine, thanks.
Is this an ack? :) > I was having a cleanup of the whole SPI/LPC bus handling in mind: Oh yes, but we'll save it for later. :) > But even without this: > Instead of unconditionally setting ich7_detected, it should only be > conditionally set if bbs == 1 (SPI) because the flag really means > "spi_strapping_detected_on_ich7" Right! What does bbs == 0 mean? chipset_enable.c prints SPI for both 1 and 0 at the moment. //Peter -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
