On 02.07.2008 00:18, Peter Stuge wrote: > Patch attached. > > I have on two occasions in a short period of time run into systems > where the pciutils check fails, while both packages are in fact > installed. In one case, no compiler was installed. The other case > has not been resolved yet, but the fact is that the check is not > precise enough. > > It is also a waste of time to do the check on every single make > invocation. >
Stefan alread commented on this. > The other hunk is about make clean. I think make clean should only > remove files that were created by other targets in the Makefile. > On principle I don't like make clean removing backups that someone > may want to keep. (I haven't gotten bit by this yet, but I would be > upset if it should happen.) > > Hope you agree on these! :) > Fully agreed on the non-removal of backup files. > flashrom: Remove Makefile pciutils check, and don't rm *~ in clean > > Signed-off-by: Peter Stuge <[EMAIL PROTECTED]> The "don't rm *~ in clean" part is Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> Regards, Carl-Daniel -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
